Added clear functionality to icon in the Input component#79
Open
mhmd21 wants to merge 4 commits intoreact-native-elements:masterfrom
mhmd21:componentsFixes
Open
Added clear functionality to icon in the Input component#79mhmd21 wants to merge 4 commits intoreact-native-elements:masterfrom mhmd21:componentsFixes
mhmd21 wants to merge 4 commits intoreact-native-elements:masterfrom
mhmd21:componentsFixes
Conversation
|
Deploy preview for rne-playground ready! Built with commit 5639802 |
Member
pranshuchittora
left a comment
pranshuchittora
left a comment
There was a problem hiding this comment.
This works but seems not the right approach. Can you fix this using the state hook
https://react-view.netlify.app/?path=/story/useview--state-hook
Author
I have changed the implementation to use the state hook instead. |
Member
|
CI is failing, can you pls pull the new changes from the master. |
Member
|
LGTM |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I have added clearing functionality to the close icon inside of the input component.
Did you add tests for your changes?
It is not needed.
If relevant, did you update the documentation?
It is irrelevant.
Summary
Attached Ref to the Input component and accessed it inside the icon's onPress function.
Issue #70.
Does this PR introduce a breaking change?
No it doesn't introduce any breaking changes.